-
Notifications
You must be signed in to change notification settings - Fork 405
relative import extensions #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
but paper over a bug in eslint-plugin-import so it doesn't warn on a false positive.
webmaster128
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
| import { AminoConverters } from "../../aminotypes.ts"; | ||
|
|
||
| // https://github.com/cosmos/ibc-go/blob/07b6a97b67d17fd214a83764cbdb2c2c3daef445/modules/core/02-client/types/client.pb.go#L297-L312 | ||
| // https://github.com/cosmos/ibc-go/blob/07b6a97b67d17fd214a83764cbdb2c2c3daef445/modules/index/core/02-client/types/client.pb.go#L297-L312 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change intentional?
| } | ||
|
|
||
| // https://github.com/cosmos/ibc-go/blob/a4ca39c59f770a0b6948947d5178d5f0914c3a17/modules/apps/transfer/types/tx.pb.go#L37-L56 | ||
| // https://github.com/cosmos/ibc-go/blob/a4ca39c59f770a0b6948947d5178d5f0914c3a17/modules/index/apps/transfer/types/tx.pb.go#L37-L56 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this
| * Performs a delegation from a delegate to a validator. | ||
| * | ||
| * @see https://docs.cosmos.network/main/build/modules/staking#msgdelegate | ||
| * @see https://docs.cosmos.network/main/build/modules/index/staking#msgdelegate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
| import js from "@eslint/js"; | ||
| import typescriptEslint from "@typescript-eslint/eslint-plugin"; | ||
| import importt from "eslint-plugin-import"; | ||
| // eslint-disable-next-line import/extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this with ignorePackages?
Groundwork for #1004