Change ts_map default MOC refinement strategy#508
Open
jdbuhler wants to merge 4 commits intocositools:developfrom
Open
Change ts_map default MOC refinement strategy#508jdbuhler wants to merge 4 commits intocositools:developfrom
jdbuhler wants to merge 4 commits intocositools:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address issue #465 , this patch changes the default pruning strategy used by MOC ts_map from top-k to containment-region-based. The top-k strategy is prone to implementation-dependent behavior when many pixels have the same likelihood (usually 0). The first test case for MOC ts_map has been updated to reflect the new default.
I incidentally fixed a couple of syntax warnings in fast_norm_fit.py caused by backslashes in docstrings.