-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scattmap and model to inject soureces #314
Conversation
Hi @israelmcmc, it seems that I have the same issue as Krishna had in his PR. My |
@Yong2Sheng I see. It seems that the issue is then caused by branching from develop and trying to merge into v0.3.0? Can you please try rebasing your branch and opening a new PR? You can do this with:
62af6b0 is the last commit in develop at the time you branch out (my commit above that says "Merge branch 'v0.3.x' into develop"). This command applies all commits in the |
|
||
if response_frame == "local" or response_frame == "galactic": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want to keep this check for either spacecraftframe or galatic ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should keep it. I will bring it back in my next push with unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this file be removed ? It looks like a personal test with personal path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It came from other's commits. This is fixed now after rebasing my PR.
Hi @GallegoSav, I am trying merge into |
60e1895
to
2fcbb88
Compare
Hi @Yong2Sheng , is this new pull request opened ? |
Hi @GallegoSav, I rebased this branch and it seems the rebase is propagated into this PR, so I don't need to open a new PR. You can continue the review from here. The test unit issue will be fixed after PR287 is merged into this PR. |
@Yong2Sheng #287 is now merged. Please check again if this fixes your unit tests. |
@israelmcmc Thank you! I will test it. |
Hi @GallegoSav, the unit test has been fixed. |
Updated
source_injector
module and tutorial notebooks to adapt to DC3:scattmap
to inject point sources when using detector response.