This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Add priority to queue settings #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corvus-ch
suggested changes
Jan 20, 2018
| @@ -63,6 +63,32 @@ const ttlConfig = `[rabbitmq] | |||
| error=a | |||
| info=b` | |||
|
|
|||
| const priorityConfig = `[rabbitmq] | |||
There was a problem hiding this comment.
Recent changes made most of the config values optional. Please remove all config values which are not required for this test.
There was a problem hiding this comment.
Like the other PR tell me if the deleted config was not what you had in mind
johnduro
force-pushed
the
add-priority
branch
from
aa00d56 to
e373d2c
Compare
corvus-ch
approved these changes
Jan 22, 2018
|
@johnduro thanks for the contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @corvus-ch ,
It's really nice that you took back ricbra consumer, i did a PR on it a while ago ( ricbra/rabbitmq-cli-consumer#56 ) and since you are the official fork i adapted it taking your modifications into account.
I added the property
x-max-priorityto the queue settings, added test and example.Tell me if you want me to do any modification.
Thanks !