Unify chunks and metadata cache backend to bucket cache #6829
+196
−154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
unify-cache-bucket
branch
from
65438c0 to
ebfe73f
Compare
SungJin1212
approved these changes
Jun 20, 2025
Signed-off-by: yeya24 <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
unify-cache-bucket
branch
from
ebfe73f to
e9a7eea
Compare
CharlieTLe
approved these changes
Jun 23, 2025
bogdan-at-adobe
pushed a commit
to bogdan-at-adobe/cortex
that referenced
this pull request
Jun 30, 2025
…t#6829) * unify chunks and metadata cache to bucket cache Signed-off-by: yeya24 <[email protected]> * update docs Signed-off-by: Ben Ye <[email protected]> * update changelog Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: yeya24 <[email protected]> Signed-off-by: Ben Ye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR tries to unify chunks cache and metadata cache backend into single bucket cache backend. This allows to support inmemory and multi level cache for metadata cache.
It allows to extend the same config for other caching bucket type we want to support in the future. We want to add cache for Parquet labels file so similar caching bucket backend can be reused.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]