Skip to content

Fix restarting query-schedulers when config changes #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nschad merged 2 commits into from
Sep 3, 2025
Merged

Fix restarting query-schedulers when config changes #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7bf35e
Fix restarting query-schedulers when config changes
friedrichg Sep 2, 2025
4c9acf1
include PR in changelog
friedrichg Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@
* [CHANGE] Change default config: distributors, rulers, queriers, query-frontend, nginx and compactors can be disrupted until 30%
* [CHANGE] Remove startup probes from compactors from default values. It's not recommended in general #542
* [CHANGE] Use default value for num_tokens in ingester configuration #544
* [DEPENDENCY] Update kiwigrid/k8s-sidecar docker tag to v1.30.5 #531
* [BUGFIX] Fix discovering memcached instances #551
* [BUGFIX] Fix restarting query-schedulers when config changes #559
* [ENHANCEMENT] Run overrides-exporter with high availability #557
* [DEPENDENCY] Update kiwigrid/k8s-sidecar docker tag to v1.30.5 #531

## 2.6.0 / 2025-05-07

Expand Down
6 changes: 1 addition & 5 deletions templates/query-scheduler/query-scheduler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,7 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
annotations:
{{- if .Values.useExternalConfig }}
checksum/config: {{ .Values.externalConfigVersion }}
{{- else }}
checksum/config: {{ include (print $.Template.BasePath "/secret.yaml") . | sha256sum }}
{{- end }}
checksum/config: {{ include "cortex.configChecksum" . }}
{{- with .Values.query_scheduler.podAnnotations }}
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down