Skip to content

plugin/node.js: don’t overwrite already-set variables #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: node-env
Choose a base branch
from

Conversation

gaelicWizard
Copy link

Description

plugin/node.js: don’t overwrite environment variables that the user may have already set:

  • $NENV_ROOT
  • $NODENV_ROOT
  • $NVM_DIR

Alsö, no need to check if directory exists before calling pathmunge as it already does so.

Motivation and Context

Just helping out 👍

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Alsö, no need to check if directory exists before calling `pathmunge` as it already does so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant