Skip to content

Conversation

@Celian-abd
Copy link
Contributor

Context

The PlanarFreeHandRoiTool crashes when we try to annotate a PT viewport. Also there is an invisible handle for the stats textbox on other viewports.
I fixed the stats calculation to be always on the volume / viewport the annotation was drawn on because sometimes for the first annotation it was bugged.
error

deplacement-cadran.mp4

Changes & Results

  • Fixed the crash when we try to annotate a PT viewport
  • Fix invisible handles for textbox
  • Fix stats calculation to always be on the correct volume / viewport

Testing

Changes can be tested on the TMTV example,I added the PlanarFreeHandRoiTool.

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link
Collaborator

@wayfarer3130 wayfarer3130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not going to accept disabling the tool on the fusion view as there is work being done to allow displaying multiple PT/CT measurements on both views.
Ideally what we want is to allow specifying which view is preferred in some way so that:

  1. If annotations are created on CT or PT views, they retain that view information
  2. If annotations are created on the fusion view, the setup can decide which volume should be used for calculations, OR specify that all volumes should be used.

That is definitely more work - is there a simple prefer first volume that would work for now and wouldn't require disabling the tool?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants