Notes quickfix #978
Open
Notes quickfix #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on and option to course card menu
Notes Basic Frontend
…ideation Backend logic, shake animation, and frontend draft for course notes
- fixed colors - fixed hover states hopefully? - fixed icons - fixed note sizes - fixed sliding + padding between courses with notes on semester - fixed z-indexes
- fixed colors - fixed hover states hopefully? - fixed icons - fixed note sizes - fixed sliding + padding between courses with notes on semester - fixed z-indexes
This reverts commit 7e33104.
|
[diff-counting] Significant lines: 810. |
|
Visit the preview URL for this PR (updated for commit f3197c8): https://cornelldti-courseplan-dev--pr978-notes-quickfix-qphhlwp5.web.app (expires Sat, 05 Apr 2025 05:56:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A quick fix for the first release of notes.
Any note in saved courses cannot be edited or deleted.
But the note on semester view works the same per usual
CoursePlan.and.22.more.pages.-.Personal.-.Microsoft.Edge.2025-03-04.17-31-39.mp4
This pull request is a part of the Notes Feature
Remaining TODOs:
Depends on #{number of PR}
Test Plan
Notes
Blockers
Breaking Changes