Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added atmospheric science minor #965

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NigelTatem
Copy link

Summary

Added the Atmospheric Science minor with full requirements.
https://www.eas.cornell.edu/eas/programs/undergraduate-programs/undergraduate-minors/atmospheric-science-minor

Remaining TODOs:

  • Add Minor Advisors

@NigelTatem NigelTatem requested a review from a team as a code owner November 20, 2024 02:23
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

@@ -475,6 +476,13 @@ const json: RequirementsJson = {
advisors: appliedMathMinorAdvisors,
abbrev: 'AppliedMath',
},
ATMOSCI: {
name: 'Atmospheric Science',
schools: ['EN'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
schools: ['EN'],
schools: ['AG', 'EN'],

Need to verify this further, but as the Department of Earth and Atmospheric Sciences seems to be in both Cornell Engineering and CALS, we probably need to add CALS to this list.

https://www.eas.cornell.edu/eas/programs/undergraduate-programs/undergraduate-minors/atmospheric-science-minor

const atmoSciMinorRequirements: readonly CollegeOrMajorRequirement[] = [
{
name: 'Two Core Courses',
description: 'Any two of these core courses: EAS 3410, EAS 3420, EAS 4470.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'Any two of these core courses: EAS 3410, EAS 3420, EAS 4470.',
description: 'Any two of the following core courses: EAS 3410, EAS 3420, EAS 4470.',

For wording consistency

{
name: 'Two Other EAS Courses',
description:
'And any two of the following EAS courses: EAS 1310, EAS 2500, EAS 2680, EAS 3050, EAS 3340, EAS 3520 ' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'And any two of the following EAS courses: EAS 1310, EAS 2500, EAS 2680, EAS 3050, EAS 3340, EAS 3520 ' +
'Any two of the following EAS courses: EAS 1310, EAS 2500, EAS 2680, EAS 3050, EAS 3340, EAS 3520 ' +

Comment on lines +45 to +48
// TODO: Add Advisors Later
export const atmoSciMinorAdvisors: AdvisorGroup = {
advisors: [],
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR specifically, but we should definitely try to get more advisor information into our requirements checklists. I can't find minor advisor information publicly, so we might have to crowdsource information from people actually in the minor/major. Perhaps a Google Form to go out on CoursePlan social media asking people for info?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants