Fix code scanning alert no. 2: Arbitrary file access during archive extraction ("Zip Slip") #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtraction ("Zip Slip")
Prevent zip extraction from processing arbitrary files.
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
This PR is stale because it has been open 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/coreybutler/nvm-windows/security/code-scanning/2
To fix the problem, we need to ensure that the file paths extracted from the zip archive do not contain any directory traversal elements like
... This can be achieved by validating the file paths before using them in file system operations.The best way to fix this problem without changing existing functionality is to:
..elements.We will add a validation step before using the file paths to create directories or files.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.