Use rocq makefile for stdlib.dev #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proux01
reviewed
Feb 5, 2025
silene
reviewed
Feb 5, 2025
To get timing information in the bench since dune doesn't support it.
SkySkimmer
force-pushed
the
stdlib-makefile
branch
from
9e91336 to
e36a4ac
Compare
|
(this would be nicer if stdlib directly supported building it with rocq makefile, without having to delete random files. All.v could also be promoted so that there's no need to run dune) |
|
This broke the build on MacOS: |
This was referenced Feb 6, 2025
|
@JasonGross I'll fix it directly in Stdlib (probably at some point next week) to avoid having to do all of that in the opam file. |
|
Can we revert this PR here in the meantime? This change is both actively breaking some of our CI developments and also makes it quite painful to upgrade Coq packages on Mac on a switch that is running dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get timing information in the bench since dune doesn't support it.