Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing rocq-bignums.dev #3330

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Add missing rocq-bignums.dev #3330

merged 1 commit into from
Feb 4, 2025

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Feb 4, 2025

Cc @proux01

Follows-up: coq-community/docker-rocq#5 (comment)

This package was missing and caused this build failure:

https://gitlab.com/coq-community/docker-rocq/-/jobs/9038615695

@erikmd
Copy link
Member Author

erikmd commented Feb 4, 2025

Once this PR is merged, I'll restart https://gitlab.com/coq-community/docker-rocq/-/pipelines/1655305693

@proux01
Copy link
Contributor

proux01 commented Feb 4, 2025

The metapackage coq-bignums.dev should also be added (can be done in a further PR).

@erikmd
Copy link
Member Author

erikmd commented Feb 4, 2025

Hi @proux01 !

Thanks for your comment → isn't https://github.com/coq/opam/blob/master/extra-dev/packages/coq-bignums/coq-bignums.dev/opam enough?

BTW I have to leave away from keyboard now;
feel free to force-push this PR anyway if you want/need.

@proux01
Copy link
Contributor

proux01 commented Feb 4, 2025

Got confused by the github interface and thought this was a rename. Still coq-bignums.dev should now just be a metapackage not installing anything, but it's more adapting than adding then.

@proux01 proux01 merged commit 6f06ae0 into coq:master Feb 4, 2025
3 checks passed
@proux01
Copy link
Contributor

proux01 commented Feb 4, 2025

@erikmd merged

@erikmd
Copy link
Member Author

erikmd commented Feb 4, 2025

I'm back.
Sorry I had opened this PR from the Web UI, and it seems it was a rename indeed.
Nevermind, I'll open a coq-bignums.dev metapackage PR now.

@erikmd erikmd deleted the patch-1 branch February 4, 2025 16:43
erikmd added a commit to erikmd/opam-coq-archive that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants