Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Autosubst 2 implemented in OCaml for Coq 8.20 #3296

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

TheoWinterhalter
Copy link
Contributor

No description provided.

@palmskog
Copy link
Collaborator

@TheoWinterhalter your PR title says "Autosubst 2", but the package description says just "Autosubst", which is likely to lead to confusion with Autosubst 1, which has a different interaction mode and interface. How about changing the package description to make this a bit clearer (at least saying "Autosubst 2")?

@TheoWinterhalter
Copy link
Contributor Author

Then this would be inconsistent with the 8.19 version. Should I update both?
I feel like this is not my prerogative since I'm not even a maintainer. Do I get your approval @yforster?

@yforster
Copy link
Contributor

Absolutely feel free to update both! (I am, however, unsure what the point of these texts is. From my perspective a link to the GitHub repository could also be good enough)

@palmskog
Copy link
Collaborator

@yforster the package description shows up on the website, when doing opam search, and hopefully in Coq Platform package collection. The goal here is just to lower the confusion around "Autosubst" for users.

@TheoWinterhalter
Copy link
Contributor Author

Alright. I added the 2 in the two 1.1 packages.

@palmskog palmskog merged commit 0e4f54e into coq:master Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants