OUT-2914 | attachments Store to attachment table when attachment is uploaded. #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- created a mechanism to support creating entries on attachments tables based on files/images uploaded on - task creation - task description update - subtask creation - subtask description update - comment/reply creation - comment/reply update - Entries on attachments table are done from api services when task/comments are created and from fronend client components when tasks/comments are edited. - Remaining: Clean deleted attachments from attachments table while clearing out scrap medias
- added a mechanism to extract attachments when comment/reply is created, move them to their respective folder and create an entry on attachments table. - Cleaning deleted attachments from attachments table while clearing out scrap medias.
…on issues. totally segregated replies/comments to have their own attachment entities
…on issues. totally segregated replies/comments to have their own attachment entities
| } | ||
| setLastUpdated(task?.lastActivityLogUpdated) | ||
| } | ||
| }, [task?.lastActivityLogUpdated]) |
Collaborator
There was a problem hiding this comment.
Let's also suppress these warning if they are intentional.
Collaborator
SandipBajracharya
left a comment
SandipBajracharya
left a comment
There was a problem hiding this comment.
I see we have drilled postAttachment() prop up to 4 levels. Is there any way we can refactor this? Maybe use context in this case if possible?
Collaborator
SandipBajracharya
left a comment
SandipBajracharya
left a comment
There was a problem hiding this comment.
Please include the testing criteria
SandipBajracharya
approved these changes
Jan 20, 2026
Collaborator
SandipBajracharya
left a comment
SandipBajracharya
left a comment
There was a problem hiding this comment.
In createUploadFn(), do we need to check for config.workspace and return undefined if not found? I saw condition check for token && tokenPayload.workspace before the refactor.
Everything else LGTM 🙌
…achment. workspaceId is needed for building folder structure effecting filePaths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing