OUT-2917: public api to list comments of a task #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SandipBajracharya
changed the title
- [x] public api route that gets list of comments for a task - [x] taskId required validation - [x] accept params: taskId, parentCommentId, createdBy - [x] include attachment in reponse with presigned download url
SandipBajracharya
force-pushed
the
OUT-2917
branch
from
185a100 to
08e8f4c
Compare
SandipBajracharya
force-pushed
the
OUT-2917
branch
from
3c523ed to
bcc44f7
Compare
SandipBajracharya
force-pushed
the
OUT-2917
branch
from
bcc44f7 to
fb80e8e
Compare
rrojan
requested changes
Jan 15, 2026
| uploadedByUserType, | ||
| uploadedDate: RFC3339DateSchema.parse(toRFC3339(attachment.createdAt)), | ||
| })) | ||
| return await Promise.all(promises) |
Collaborator
There was a problem hiding this comment.
Is there a chance that we will hit supabase api per sec ratelimits if there are 50+ attachments?
Collaborator
Author
There was a problem hiding this comment.
Used supabase storage's createSignedUrls() to resolve this.
Comment on lines
+285
to
+291
| return await this.db.comment.findMany({ | ||
| where, | ||
| ...pagination, | ||
| include: { attachments: true }, | ||
| orderBy: { createdAt: 'desc' }, | ||
| }) | ||
| } |
Collaborator
There was a problem hiding this comment.
Is the comments table properly indexed here, can you please check
Collaborator
Author
There was a problem hiding this comment.
created composite index with taskId, workspaceId, createdAt DESC.
rrojan
requested changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing Criteria
Loom