Feature/tech-debt-bash-2 #1082
Open
Feature/tech-debt-bash-2 #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create a new tab design using Tabs and Tab component from mui. - replaced buttons group with the tabs. - designed a new dropdown to replace filter by user types in mobile devices.
- changed colors of list view headers. The colors are conditional to the workflowstate type.
- instead of nested scrolls, added a sticky header with a single overall scroll. - to do this, removed the nested scroll functionality, passed parent scroll ref to the column virtualizer and added sticky push up header style. - fixed the tab indicator placement.
…choppy scroll mechanism. better than before
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
arpandhakal
force-pushed
the
feature/tdb2
branch
from
1bb373d to
cd888d0
Compare
arpandhakal
force-pushed
the
feature/tdb2
branch
from
369b9a4 to
4d5f50b
Compare
arpandhakal
force-pushed
the
feature/tdb2
branch
from
d0769c7 to
e49cdf5
Compare
…property in Templates response for public API.
…llBar component from details page
- created a separate RealtimeTemplatesHandler class with all the methods to entertain templates realtime logic. - cleaned the RealtimeTemplates HOC to only points to relevant methods in the RealtimeTempaltesHandler class.
- created a separate service file name public.service for tasks - created a separate abstract service which inherits base service and extended by PublicTasksService and TasksService. This file contains all the utilities shared by both of the services. - changed methods in public.controller for tasks - refactored tasks service
…rom both services using the template pattern
…pe of utility methods
arpandhakal
force-pushed
the
feature/tdb2
branch
from
e49cdf5 to
4d0259b
Compare
- endOptions and endOptions href were not being caught simply from ListBoxComponent. Needed to pass the props in a custom manner using ListboxProps and some tweaks. The cause for this might be the version upgrade. - refactored the selector/listBox component solving all 7 incoming warnings.
* fix(out-2943): fix alignment of search and filter icons
…4 errors on withRetry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes