OUT-2888: check for incorrectly created invoice in inactive portals #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] create a command that compares invoices from Assembly and QBO for portals
- [x] list out the diff of invoices that only exists in QBO
Check for impacted portals which are inactive
- [x] migration to create table `portal_impact_verification` that holds the potential impacted portals.
- these portals are check for incorrectly synced invoices when re-auth
- [x] report to sentry with details if found
…et incorrect sync in response
…max invoice fetch limit change
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rrojan
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
portal_impact_verificationthat holds the potential impacted portals.- these portals are check for incorrectly synced invoices when re-auth
Note
I've decided not to automate the invoice deletion in portal's QBO account. This is because we have to verify the invoice items, customer, absorbed fees. I think it would be better if we handle this manually when reported by sentry.