fix: resolve race condition causing cross-workspace invoice sync #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static properties in InvoiceService and IntuitAPI were shared across concurrent webhook requests, causing invoices to be synced to the wrong QuickBooks company when multiple webhooks processed simultaneously. Changes: - Convert InvoiceService.intuitApiService from static to instance property - Convert InvoiceService.oneOffItem from static to instance property - Convert InvoiceService.incomeAccountRef from static to instance property - Convert IntuitAPI.headers from static to instance property This ensures each request maintains its own IntuitAPI instance with the correct realm ID and credentials throughout the entire request lifecycle. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
makeitraina
commented
Jan 6, 2026
| private static intuitApiService: IntuitAPI | ||
| private static oneOffItem: OneOffItemType | ||
| private static incomeAccountRef: string | ||
| private intuitApiService!: IntuitAPI |
Member
Author
There was a problem hiding this comment.
i dont like this !, i need this to pass ci to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
InvoiceServiceandIntuitAPIwere shared across all concurrent requests, allowing one request to overwrite another's QuickBooks credentials mid-processingChanges
InvoiceService.intuitApiServicefrom static to instance propertyInvoiceService.oneOffItemfrom static to instance propertyInvoiceService.incomeAccountReffrom static to instance propertyIntuitAPI.headersfrom static to instance propertyEvidence
Vercel logs showed realm ID changing mid-request:
16:09:16.830-getAnAccountused realm123145893478919(workspace A - correct)16:09:18.041- Concurrent webhook from workspace B started16:09:18.923-getACustomerused realm1372015430(workspace B - wrong!)A concurrent webhook overwrote the static
IntuitAPIinstance, causing workspace A's invoice to be created in workspace B's QuickBooks company.Test plan
🤖 Generated with Claude Code