Skip to content

OUT-2842: responsive UI for mapping table #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SandipBajracharya merged 4 commits into from
Dec 25, 2025
Merged

OUT-2842: responsive UI for mapping table #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f285c2
fix(OUT-2842): responsive UI for mapping table
SandipBajracharya Dec 25, 2025
6cdbafe
docs(OUT-2842): add note to create react portal if the UI responsive …
SandipBajracharya Dec 25, 2025
3b1838c
docs(OUT-2842): edit code comment
SandipBajracharya Dec 25, 2025
eb7aa5a
style(OUT-2842): fix table borders
SandipBajracharya Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ export default function RootLayout({
}>) {
return (
<html lang="en">
<body className={`${inter.className} min-h-[100vh] bg-white antialiased`}>{children}</body>
<body className={`${inter.className} flex min-h-screen flex-col bg-white antialiased`}>
{children}
</body>
</html>
)
}
2 changes: 2 additions & 0 deletions src/components/ui/CopilotSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ export const CopilotSelector = ({
}: CopilotSelectorProps) => {
if (typeof window !== 'undefined')
return (
// Note: if in case the UI responsive issue does not work in the future, need to create a custom react portal and wrap this component with it.
// Since we are using the same input field given by this selector component for now, need to create a separate input field for this implementation
<div className="w-64">
<UserCompanySelector
name={name}
Expand Down
44 changes: 23 additions & 21 deletions src/features/sync/components/Table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,27 +177,29 @@ export const MappingTable = () => {
const { openDialog, setOpenDialog, handleRemoveSync, openConfirmDialog } = useRemoveChannelSync()

return (
<div className="m-10 mt-0 border border-gray-200 bg-white">
<table className="w-full">
<thead className="border-gray-200 border-b bg-gray-50">
<tr>
{columns.map((column) => (
<th
key={column.key}
className={cn(
'px-6 py-3 text-left font-medium text-gray-500 text-xs uppercase',
column.className,
)}
>
{column.title}
</th>
))}
</tr>
</thead>
<tbody className="divide-y divide-gray-200 bg-white">
<MappingTableRow openConfirmDialog={openConfirmDialog} />
</tbody>
</table>
<div className="m-10 mt-0 min-h-0 flex-1 overflow-x-auto">
<div className="h-full w-full">
<table className="w-full">
<thead className="border border-gray-200 bg-gray-50">
<tr>
{columns.map((column) => (
<th
key={column.key}
className={cn(
'px-6 py-3 text-left font-medium text-gray-500 text-xs uppercase',
column.className,
)}
>
{column.title}
</th>
))}
</tr>
</thead>
<tbody className="divide-y divide-gray-200 border border-gray-200 bg-white">
<MappingTableRow openConfirmDialog={openConfirmDialog} />
</tbody>
</table>
</div>
{openDialog && (
<Dialog
open={openDialog}
Expand Down