Skip to content

test: add test that preserved symlinks are not followed#2457

Draft
sisp wants to merge 2 commits intomasterfrom
test/preserved-symlink-not-followed
Draft

test: add test that preserved symlinks are not followed#2457
sisp wants to merge 2 commits intomasterfrom
test/preserved-symlink-not-followed

Conversation

@sisp
Copy link
Member

@sisp sisp commented Jan 13, 2026

WDYT @cbrown1234?

@sisp sisp marked this pull request as draft January 13, 2026 14:10
@sisp
Copy link
Member Author

sisp commented Jan 13, 2026

Odd, the test is passing on my Ubuntu locally. 🤔

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.77%. Comparing base (41cb45c) to head (7cdd1de).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2457      +/-   ##
==========================================
- Coverage   97.16%   96.77%   -0.39%     
==========================================
  Files          55       55              
  Lines        6352     6364      +12     
==========================================
- Hits         6172     6159      -13     
- Misses        180      205      +25     
Flag Coverage Δ
unittests 96.77% <100.00%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sisp
Copy link
Member Author

sisp commented Jan 13, 2026

I guess the order in which the template files are iterated over is non-deterministic. 💡

@sisp sisp force-pushed the test/preserved-symlink-not-followed branch from 7cdd1de to ca269d0 Compare January 13, 2026 20:17
@sisp sisp force-pushed the test/preserved-symlink-not-followed branch from ca269d0 to 4b5085f Compare January 14, 2026 12:43
@sisp sisp force-pushed the test/preserved-symlink-not-followed branch from 4b5085f to 310048a Compare January 20, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant