Skip to content

feat: Add kubernetes targets#547

Merged
AtzeDeVries merged 30 commits intomainfrom
add-kubernetes
Mar 9, 2026
Merged

feat: Add kubernetes targets#547
AtzeDeVries merged 30 commits intomainfrom
add-kubernetes

Conversation

@AtzeDeVries
Copy link
Contributor

@AtzeDeVries AtzeDeVries commented Feb 27, 2026

This will add Kubernetes targets.

Features:

  • Auto detect helm charts and guess environments from file names. This means that kustomize is not supported.
  • Diff will be done against the main branch and not on the current status in ArgoCD. ArgoCD is not a requirement for the workflow anymore. Diffs will be posted as github comments
  • Adds a bunch of feature related to github
    • Create comments
    • Hide comments
    • Annotate logs in actions with a level (error, warn, debug, notice)
    • Create logs groups in github actions

Note: Kyverno will be added in a later stage.

Demo PR: https://github.com/coopnorge/helloworld/pull/3285

Some screenshots

Screenshot 2026-03-04 at 15 37 48 Screenshot 2026-03-04 at 15 39 08

This will add kubernetes targets. This assuming you are having helm
charts. It will detect those and do validation and diffing magic on
them.

Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
@AtzeDeVries AtzeDeVries marked this pull request as ready for review March 4, 2026 15:13
@alfredosa
Copy link
Contributor

From a first pass it looks good.

Target -> run -> runInDocker -> runLocal... I am curious if that can be abstracted

But it looks okay. I think it would be best to split it into smaller targets tho but I'm okay to move if you want.

I also see that there is a core focus on e2e but I don't see a lot of unit testing to ensure behavior

Copy link
Contributor

@bendiknesbo bendiknesbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not reviewed the usage of Kubeconform or Kubescore

Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
@AtzeDeVries
Copy link
Contributor Author

From a first pass it looks good.

Target -> run -> runInDocker -> runLocal... I am curious if that can be abstracted

But it looks okay. I think it would be best to split it into smaller targets tho but I'm okay to move if you want.

I also see that there is a core focus on e2e but I don't see a lot of unit testing to ensure behavior

The .Run/other funcs' could be abstracted in someway but they are all a bit different to best support the requirements of a tool.

The e2e is now a bit less and more focused on unit tests. Moving all devtools and it configurations (like lint config etc) under devtools allows better unit testing.

We should check if we can do testing on the targets in a way that we make sure all targets and its depenencies are run (preferable in a 'dryrun' like mode.

Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
alfredosa
alfredosa previously approved these changes Mar 6, 2026
Copy link
Contributor

@alfredosa alfredosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after enhancements (and issue opened)

Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
@policy-bot-coop-norge policy-bot-coop-norge bot dismissed alfredosa’s stale review March 6, 2026 10:40

Invalidated by push of 5b47d37

Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
…predefined environment list

Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
@AtzeDeVries AtzeDeVries merged commit 637a2b4 into main Mar 9, 2026
19 checks passed
@AtzeDeVries AtzeDeVries deleted the add-kubernetes branch March 9, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants