Conversation
This will add kubernetes targets. This assuming you are having helm charts. It will detect those and do validation and diffing magic on them. Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
96fa33b to
97e79ed
Compare
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
97e79ed to
8d0b265
Compare
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
|
From a first pass it looks good. Target -> run -> runInDocker -> runLocal... I am curious if that can be abstracted But it looks okay. I think it would be best to split it into smaller targets tho but I'm okay to move if you want. I also see that there is a core focus on e2e but I don't see a lot of unit testing to ensure behavior |
bendiknesbo
left a comment
There was a problem hiding this comment.
I have not reviewed the usage of Kubeconform or Kubescore
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
The .Run/other funcs' could be abstracted in someway but they are all a bit different to best support the requirements of a tool. The e2e is now a bit less and more focused on unit tests. Moving all devtools and it configurations (like lint config etc) under devtools allows better unit testing. We should check if we can do testing on the targets in a way that we make sure all targets and its depenencies are run (preferable in a 'dryrun' like mode. |
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
alfredosa
left a comment
There was a problem hiding this comment.
lgtm after enhancements (and issue opened)
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Invalidated by push of 5b47d37
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
…predefined environment list Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
This will add Kubernetes targets.
Features:
Note: Kyverno will be added in a later stage.
Demo PR: https://github.com/coopnorge/helloworld/pull/3285
Some screenshots