Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move third party packages #131

Open
tlmquintino opened this issue Oct 19, 2011 · 6 comments
Open

move third party packages #131

tlmquintino opened this issue Oct 19, 2011 · 6 comments
Assignees

Comments

@tlmquintino
Copy link
Member

I think the current /include parallel to cf3/ is not convenient.
Third party packages should be in cf3/third_party or cf3/other.
When deploying then we just have to deploy the entire cf3 directory.

I vote for cf3/other

@ghost ghost assigned tlmquintino Oct 19, 2011
@tlmquintino
Copy link
Member Author

I can do the move together with the src/ in issue #62

@wdeconinck
Copy link
Member

Your argument is to deploy coolfluid inside a "cf3" include dir
How about our kernel plugins then? Should those now not also go in cf3/plugins/ ?
And external plugins, should then also install there?

@wdeconinck
Copy link
Member

by the way, I vote for "cf3/external" or "cf3/deps" (in which we could also install then other third party deps) :p

@tlmquintino
Copy link
Member Author

Yes, IMO, we should deploy everything inside a cf3/ directory.
Internal and external plugins should go into cf3/plugins.
Third-party packages that we are hard bound to - Eigen, fparser, etc - should go into cf3/external.
We should never install anything out of cf3/.

@tlmquintino
Copy link
Member Author

cf3/external is a good place.

@tlmquintino
Copy link
Member Author

My argument is also that the developer tree should be as similar to the deployment tree as possible.
The only exception will be the external plugins, but that really makes sense to exist in a a separate developer tree, since they may be hosted in a totally different source control system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants