Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always include complete paths #138

Closed
tlmquintino opened this issue Oct 21, 2011 · 4 comments
Closed

always include complete paths #138

tlmquintino opened this issue Oct 21, 2011 · 4 comments
Assignees
@tlmquintino
Labels
BUILD

Comments

@tlmquintino
Copy link
Member

IMO, we should always include the complete paths to the files that are managed by us:

include "cf3/external/fparser/fparser.h"

include "cf3/common/component.hpp"

include "cf3/math/real_vector.hpp"

This will clarify what we are using and avoid weird header clashes once the software is deployed by installing the SDK.
@ghost ghost assigned tlmquintino Oct 21, 2011
@tlmquintino
Copy link
Member Author

This is related to issue #131, and only make sense once that is implemented.

@tbanyai
Copy link
Member

tbanyai commented Oct 21, 2011

totally agree, especially when you make install

@barche
Copy link
Member

barche commented Oct 22, 2011

Agreed!

@wdeconinck
Copy link
Member

I think we can close this. Seems like common practise everywhere now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlmquintino tlmquintino

Labels
BUILD
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wdeconinck @tlmquintino @barche @tbanyai