Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged settings and participants list #821

Closed
wants to merge 1 commit into from

Conversation

jhthorsen
Copy link
Collaborator

@jhthorsen jhthorsen commented Jan 12, 2023

One thing that has bugged me for a long time is how it's so difficult to get to settings for a Conversation or Connection.

This PR is a Work In Progress, but I'm opening for discussion. Here is screenshot taken from this PR:

Screenshot 2023-01-12 at 10 05 27

Summary:

  • The settings will be collapsed by default, but accessible just by toggling the checkbox.
  • The participant groups will be open by default, but can be collapsed.
  • No magical cogwheel in the main menu.

Not sure about:

  • Should the "Leave" button be inside settings? I'm also considering just adding a "X", since leaving a channel is a non-destructive action. (Nothing gets deleted)
  • Do we need a "Save" button for settings?
  • Should the top bar stretch from side to side?
  • Should the topic box be inside settings or somewhere else? Can it replace the truncated topic in the header? Or should it be a supplement?

TODO:

  • All of the above...
  • Add number of operators, members, ...
  • Add a toggle for hiding the whole sidebar Hide/fold side panels  #746
  • Store the (un)collapsed state in browser's localStorage.

@jhthorsen jhthorsen added this to the 7.xx milestone Jan 12, 2023
@jhthorsen jhthorsen self-assigned this Jan 12, 2023
@jhthorsen jhthorsen marked this pull request as draft January 12, 2023 01:16
@poVoq
Copy link

poVoq commented Jan 12, 2023

This translates not very well to mobile use I think.

I agree that currently it is a bit counter intuitive (on desktop at least) that the channel settings button opens a settings menu on the opposite side of the screen over the channel list. But in general having an easily accessible (and touch screen ready) channel settings button seems like not such a bad idea.

I think tiny collapsible harmonicas work somewhat ok with mouse input, but are already annoying when using touchpad and keyboard mostly.

@jhthorsen
Copy link
Collaborator Author

This translates not very well to mobile use I think.

The mobile version will stay the same as today.

I think tiny collapsible harmonicas work somewhat ok with mouse input, but are already annoying when using touchpad and keyboard mostly.

The size is the same for all checkboxes, so if there's an issue with that it has to be addressed globally.

@jhthorsen jhthorsen modified the milestones: 7.xx, 8.xx Oct 27, 2023
@jhthorsen
Copy link
Collaborator Author

This is part of v8.01.

@jhthorsen jhthorsen closed this Oct 27, 2023
@jhthorsen jhthorsen deleted the settings-and-participants branch October 27, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants