Skip to content

Commit

Permalink
[Github CI] Attempt to fix macOS code signing
Browse files Browse the repository at this point in the history
Signed-off-by: Christian Parpart <[email protected]>
  • Loading branch information
christianparpart committed Jul 3, 2024
1 parent ff7fc99 commit 580f775
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -385,10 +385,13 @@ jobs:
run: |
# create variables
CERTIFICATE_PATH=$RUNNER_TEMP/build_certificate.p12
PP_PATH=$RUNNER_TEMP/build_pp.mobileprovision
PP_PATH=$RUNNER_TEMP/build_pp.provisionprofile
KEYCHAIN_PATH=$RUNNER_TEMP/app-signing.keychain-db
# import certificate and provisioning profile from secrets
echo "certificate:"
echo "$BUILD_CERTIFICATE_BASE64"
echo ""
echo -n "$BUILD_CERTIFICATE_BASE64" | base64 --decode -o $CERTIFICATE_PATH
echo -n "$BUILD_PROVISION_PROFILE_BASE64" | base64 --decode -o $PP_PATH
Expand Down
1 change: 1 addition & 0 deletions metainfo.xml
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@
<release version="0.4.4" urgency="medium" type="development">
<description>
<ul>
<li>macOS package signing is now done with a valid Apple ID</li>
<li>macOS package is now Apple Silicon native</li>
<li>Add CoreText font fallback implementation for macOS (#1533)</li>
<li>Add Ubuntu-24.04 in github actions (#1460)</li>
Expand Down
1 change: 1 addition & 0 deletions src/contour/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ elseif(APPLE)

# Install application icon
install(FILES "res/images/contour-logo.icns" DESTINATION "${INSTALL_CMAKE_DIR}" RENAME "contour.icns")
install(FILES "res/entitlements.plist" DESTINATION "${App_Contents}")
install(DIRECTORY "${terminfo_basedir}" DESTINATION "${INSTALL_CMAKE_DIR}")
install(DIRECTORY "shell-integration" DESTINATION "${INSTALL_CMAKE_DIR}")

Expand Down
10 changes: 10 additions & 0 deletions src/contour/res/entitlements.plist
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<!--?xml version="1.0" encoding="UTF-8"?-->
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.application-identifier</key>
<string>org.contourterminal.Terminal</string>
<key>com.apple.developer.team-identifier</key>
<string>6T525MU9UR</string>
</dict>
</plist>

0 comments on commit 580f775

Please sign in to comment.