-
Notifications
You must be signed in to change notification settings - Fork 4k
fix: handle non-file URI schemes in runTerminalCommand for WSL2 #9325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RomneyDa
merged 8 commits into
continuedev:main
from
shanevcantwell:fix/wsl2-terminal-command-uri
Jan 14, 2026
+270
−1
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
788e253
fix: wrap fileURLToPath in try-catch for WSL2 compatibility
shanevcantwell eab2ac1
fix: properly resolve WSL2 workspace paths in runTerminalCommand
shanevcantwell 074a6c7
fix: decode URI-encoded pathname for WSL workspace paths
shanevcantwell 3ef9f89
test: add comprehensive tests for WSL workspace path resolution
shanevcantwell 27adb1d
fix: use try/finally for env cleanup in test
shanevcantwell e251113
docs: add CLAUDE.md with WSL2 development notes
shanevcantwell 6b30a88
style: fix prettier formatting
shanevcantwell 8e5a7c2
refactor: generalize remote URI handling and remove CLAUDE.md
shanevcantwell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way we could write this that isn't so specific to
vscode-remote://wsl? I suppose the same issue applies to any non-file URIs? If not obvious this is fine for now but it feels a bit specificThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, that was overly narrow. I'll re-submit with it more widely applicable.