Skip to content

fix: handle non-file URI schemes in runTerminalCommand for WSL2 #9325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RomneyDa merged 8 commits into from
Jan 14, 2026
+270 −1
Merged

fix: handle non-file URI schemes in runTerminalCommand for WSL2 #9325

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
788e253
fix: wrap fileURLToPath in try-catch for WSL2 compatibility
shanevcantwell Dec 26, 2025
eab2ac1
fix: properly resolve WSL2 workspace paths in runTerminalCommand
shanevcantwell Dec 26, 2025
074a6c7
fix: decode URI-encoded pathname for WSL workspace paths
shanevcantwell Dec 26, 2025
3ef9f89
test: add comprehensive tests for WSL workspace path resolution
shanevcantwell Dec 26, 2025
27adb1d
fix: use try/finally for env cleanup in test
shanevcantwell Dec 26, 2025
e251113
docs: add CLAUDE.md with WSL2 development notes
shanevcantwell Dec 26, 2025
6b30a88
style: fix prettier formatting
shanevcantwell Dec 26, 2025
8e5a7c2
refactor: generalize remote URI handling and remove CLAUDE.md
shanevcantwell Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/tools/implementations/runTerminalCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,12 @@ function resolveWorkingDirectory(workspaceDirs: string[]): string {
dir.startsWith("file:/"),
);
if (fileWorkspaceDir) {
return fileURLToPath(fileWorkspaceDir);
try {
return fileURLToPath(fileWorkspaceDir);
} catch {
// fileURLToPath can fail on malformed URIs or in some remote environments
// Fall through to default handling
}
}
// Default to user's home directory with fallbacks
try {
Expand Down
Loading