Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Dec 17, 2025

Description

Allow selecting images using cmd/ctrl+a.

resolves CON-5056

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

before.mp4
after.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Enable Cmd/Ctrl+A to select all content in the TipTap editor, including images, with a clear outline on selected images. Resolves CON-5056.

  • New Features
    • Override Mod-a to select the full document (text and images).
    • Add selection decorations for image nodes and a .selected-image CSS outline for visual feedback.

Written for commit e31605a. Summary will update automatically on new commits.

@uinstinct uinstinct requested a review from a team as a code owner December 17, 2025 14:42
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team December 17, 2025 14:42
@continue
Copy link
Contributor

continue bot commented Dec 17, 2025

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts


Unsubscribe from All Green comments

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 17, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 7, 2026
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jan 7, 2026
@RomneyDa RomneyDa merged commit 21c0457 into continuedev:main Jan 7, 2026
58 of 59 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jan 7, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2026
@uinstinct uinstinct deleted the select-images branch January 8, 2026 03:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants