feat: add rootUrl param to docs and improve page selection #7049
+93
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shssoichiro
commented
Aug 7, 2025
| private readonly maxRequestsPerCrawl: number, | ||
| private readonly maxDepth: number, | ||
| ) {} | ||
|
|
||
| async crawl(): Promise<PageData[]> { | ||
| // TODO: How do we edit the remote crawler? I see there is a `control-plane` folder |
There was a problem hiding this comment.
I opened this as a draft because I'm stuck on this portion. I'm not sure where the code for the remote crawler lives, but it will need updated in order to use the root URL.
There was a problem hiding this comment.
@RomneyDa Would you happen to have any knowledge on the remote crawler?
shssoichiro
force-pushed
the
issue-3823
branch
from
603449e to
108cd3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rootUrlparam (optional) to docs sites to match against for selecting subpages when crawlingrootUrlis not specified, infer it from thestartUrlrootUrlwhen crawling to include the correct pages that are part of the desired documentationFixes #3823
Checklist
Screen recording or screenshot
N/A
Tests
TODO
Summary by cubic
Added an optional rootUrl parameter for docs sites to improve how subpages are selected during crawling. If rootUrl is not set, it is now inferred from startUrl for more accurate page inclusion.