-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix: 🐛 Codebase Indexing still not work #6032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 Codebase Indexing still not work #6032
Conversation
Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic. |
✅ Deploy Preview for continuedev canceled.
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
100% agree. I caught 1 more of these during the subsequent refactoring use but you caught a few more yet. Appreciate it! |
I have read the CLA Document and I hereby sign the CLA |
recheck |
Perhaps worth a quick double check that the changes in #5564 which I just merged are valid as well. |
Description
@chezsmithy @Patrick-Erichsen after refactoring in this PR #5894 and #5993 codebasing indexing still is not working properly. After starting extension, initialization message appears but process does not start. Problem is not with line:
await this.codeBaseIndexer.refreshCodebaseIndex(dirs);
which was replaced by the line below:
void this.codeBaseIndexer.refreshCodebaseIndex(dirs);
The problem is that during refactoring the lines with:
void this.messenger.request...
have been replaced by:
await this.messenger.request...
And we will never get response from messenger. The code works correctly before the refactor because it didn't wait for responses. In
useWebviewListener
we are unable to check whether the listener service has ended:window.addEventListener("message", listener);
Checklist
Screenshots
[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]
Tests
Tested through visual inspection of loading the extension in the debugger and observing indexing now seems to start as expected.