Skip to content

fix: 🐛 Codebase Indexing still not work #6032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

owl-app
Copy link

@owl-app owl-app commented Jun 8, 2025

Description

@chezsmithy @Patrick-Erichsen after refactoring in this PR #5894 and #5993 codebasing indexing still is not working properly. After starting extension, initialization message appears but process does not start. Problem is not with line:

await this.codeBaseIndexer.refreshCodebaseIndex(dirs);

which was replaced by the line below:

void this.codeBaseIndexer.refreshCodebaseIndex(dirs);

The problem is that during refactoring the lines with:

void this.messenger.request...

have been replaced by:

await this.messenger.request...

And we will never get response from messenger. The code works correctly before the refactor because it didn't wait for responses. In useWebviewListener we are unable to check whether the listener service has ended:

window.addEventListener("message", listener);

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

Tested through visual inspection of loading the extension in the debugger and observing indexing now seems to start as expected.

@owl-app owl-app requested a review from a team as a code owner June 8, 2025 13:47
@owl-app owl-app requested review from tomasz-stefaniak and removed request for a team June 8, 2025 13:47
Copy link

cubic-dev-ai bot commented Jun 8, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

Copy link

netlify bot commented Jun 8, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 955ab93
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/68459469e30802000800208b

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 8, 2025
Copy link

github-actions bot commented Jun 8, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@chezsmithy
Copy link
Contributor

100% agree. I caught 1 more of these during the subsequent refactoring use but you caught a few more yet. Appreciate it!

@owl-app
Copy link
Author

owl-app commented Jun 8, 2025

I have read the CLA Document and I hereby sign the CLA

@Patrick-Erichsen Patrick-Erichsen requested review from Patrick-Erichsen and removed request for tomasz-stefaniak June 9, 2025 20:18
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 9, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 9, 2025
@Patrick-Erichsen
Copy link
Collaborator

recheck

@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 9, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Issues and PRs Jun 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2025
@Patrick-Erichsen
Copy link
Collaborator

Perhaps worth a quick double check that the changes in #5564 which I just merged are valid as well.

@Patrick-Erichsen Patrick-Erichsen merged commit 7140451 into continuedev:main Jun 9, 2025
64 of 65 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants