Make ComPtr results optional #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not wrap the result in Option for - factory methods - IAsync... results
Boddlnagg
force-pushed
the
optional-comptr
branch
from
601f23d to
9735cad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most methods returning interface/class types could return
null, so we need to returnOption<ComPtr<T>>. Fixes #20.Return values from factory methods as well as
IAsync...return types are not wrapped inOption, because the former are projected as constructors in C# (which cannot returnnull), and the latter are meant to be used withawaitsyntax in C#, which can not deal withnull(see dotnet/roslyn#7171).In this PR I also finally removed the
unsafemodifier from wrapper methods, because I'm sufficiently sure that these methods should be safe, and if some are not (as currently defined), then that's a bug in winrt-rust.