-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Run formatter on all the python files #75
Open
gpeacock
wants to merge
2
commits into
main
Choose a base branch
from
gpeacock/formatting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
// Purpose: Generate the scaffolding for the uniffi library. | ||
fn main() { | ||
uniffi::generate_scaffolding("./src/c2pa.udl").unwrap(); | ||
let _result = uniffi::generate_scaffolding("./src/c2pa.udl"); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
from .c2pa_api import * | ||
from .c2pa_api import * |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ | |
use std::env; | ||
use std::sync::RwLock; | ||
|
||
pub use c2pa::{Signer, SigningAlg}; | ||
pub use c2pa::{Signer, SigningAlg, settings::load_settings_from_str}; | ||
|
||
/// these all need to be public so that the uniffi macro can see them | ||
mod error; | ||
|
@@ -45,6 +45,11 @@ pub fn sdk_version() -> String { | |
) | ||
} | ||
|
||
pub fn load_settings(settings: &str, format: &str) -> Result<()> { | ||
load_settings_from_str(settings, format)?; | ||
Ok(()) | ||
} | ||
|
||
pub struct Reader { | ||
reader: RwLock<c2pa::Reader>, | ||
} | ||
|
@@ -102,6 +107,14 @@ impl Reader { | |
} | ||
} | ||
|
||
// pub fn validation_state(&self) -> Result<ValidationState> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it debug code? |
||
// if let Ok(st) = self.reader.validation_state() { | ||
// Ok(st.validation_state()) | ||
// } else { | ||
// Err(Error::RwLock) | ||
// } | ||
// } | ||
|
||
pub fn resource_to_stream(&self, uri: &str, stream: &dyn Stream) -> Result<u64> { | ||
if let Ok(reader) = self.reader.try_read() { | ||
let mut stream = StreamAdapter::from(stream); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never saw the syntax with parenthesis before, hope it doesn't have adverse strange side-effects. After researching it, that's allowed only for Python 3.10 and later, so Python-wise should be fine.