fix: Rename CStream to C2paStream to avoid collisions #55
+794
−647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework platform macros for consistency Rename Exception to C2paException C functions that return lengths now return int64_t
CMake cleanup Lib export macro rework
dyro
approved these changes
Feb 28, 2025
|
Code looks good! |
Removes C++ openssl dependency for tests
This commit adds the "make test" command to our workflows, so we can test our Rust, C, and CPP functionality in c2pa-c.
remove test_signer
Also removes including the dll at the linking libraries call and instead brings in the .lib file only - as this appears to be the right way of going about it.
fix: repair some leaked memory on error conditions
…/c2pa-c into gpeacock/c2pa_stream
|
Merging to main with one unit test not working on linux and unit tests not running on windows - will fix these soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note this is a breaking change, some APIs have been renamed or modified.
New C2paSigner constructor that leverages Rust based openssl
removed test_signer since it required C level linking with openssl
Rework platform macros for consistency
Renames Exception to C2paException
Renames CStream to C2paStream
Renames TestCStream to TestC2paStream
C functions that return lengths now return int64_t
Renames C2PA_EXPORT to C2PA_API