Skip to content

Conversation

@kostiantynperehuda
Copy link
Contributor

This change allows the project to be included as a subdirectory in another CMake project using add_subdirectory()

@yogeshbdeshpande
Copy link

Please note that the ADOBE CLA was signed from Arm as an organisation so this contribution needs to proceed now.

Also, request add suitable reviewer to the PR and please provide review comments and approve.

Thanks for all help.

If any questions: Please contact [email protected]

@yogeshbdeshpande
Copy link

@gpeacock : Please add suitable reviewers

@scouten-adobe scouten-adobe self-assigned this Nov 3, 2025
@scouten-adobe
Copy link
Contributor

@yogeshbdeshpande I'm tracking down why the CLA bot isn't recognizing your signature.

@scouten-adobe
Copy link
Contributor

@yogeshbdeshpande I think this might be an issue if you signed the CLA instead of @kostiantynperehuda.

@gpeacock gpeacock requested a review from tmathern November 3, 2025 21:06
@gpeacock gpeacock requested a review from dyro November 3, 2025 21:07
@gpeacock
Copy link
Contributor

gpeacock commented Nov 3, 2025

I'm ok with this change, I just want to make sure that it doesn't impact existing projects that depend on this. @dyro @tmathern

@yogeshbdeshpande
Copy link

@yogeshbdeshpande I think this might be an issue if you signed the CLA instead of @kostiantynperehuda.
I signed the CLA on behalf of my organisation, which is Arm.

So we believe any Arm individual should be able to submit the same!

@scouten-adobe
Copy link
Contributor

@yogeshbdeshpande I think this might be an issue if you signed the CLA instead of @kostiantynperehuda.
I signed the CLA on behalf of my organisation, which is Arm.

So we believe any Arm individual should be able to submit the same!

In principle, I'd agree with you, but I don't think our bot is smart enough to identify the relevant company. In any case, I'll merge once @dyro and @tmathern have reviewed. This may take another day or two there is a one-day PTO involved for one of them.

Copy link
Collaborator

@dyro dyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyro
Copy link
Collaborator

dyro commented Nov 4, 2025

Merging with two failures:

  1. CLA issues, which is discussed above.
  2. "Build and publish docs" is failing because this is on a fork. Will try to re-run this job manually when the changes make it to main.

@dyro dyro merged commit 3278d84 into contentauth:main Nov 4, 2025
4 of 6 checks passed
@yogeshbdeshpande
Copy link

Thank you @gpeacock and @dyro for your timely help

May I request please also review PR #104 and provide your valuable guidance...

@kostiantynperehuda
Copy link
Contributor Author

Thank you all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants