Packit: use post-modifications hook to update downstream TMT plan
#2763
Conversation
|
cc @inknos RE: similar changes in podman-py. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
|
.packit.yaml
Outdated
| prepare-files: >- | ||
| bash -c "sed -i 's/^\(\s*\)ref: .*/\1ref: \"${PACKIT_PROJECT_TAG}\"/' ${PACKIT_DOWNSTREAM_REPO}/plans/main.fmf" | ||
| post-modifications: >- | ||
| bash -c "sed -i 's/^\(\s*\)ref: .*/\1ref: \"v${PACKIT_PROJECT_VERSION}\"/' ${PACKIT_DOWNSTREAM_REPO}/plans/main.fmf" |
There was a problem hiding this comment.
is PACKIT_DOWNSTREAM_REPO the right variable to use?
There was a problem hiding this comment.
It's a path to cloned dist-git repo, so yes, I would say it's right. Out of curiosity, why do you ask? Does the name seem out of place?
There was a problem hiding this comment.
I would say so: https://packit.dev/docs/configuration/actions#run-condition-1
There was a problem hiding this comment.
I got confused by seeing the variable empty in the tests and then I checked here and found PACKIT_DOWNSTREAM_NAME and PACKIT_DOWNSTREAM_URL. I guess my bad
|
ah I gotta move the post-modifications to the propose-downstream job probably. Otherwise it's trying to mess with copr builds too. |
lsm5
force-pushed
the
packit-fix
branch
2 times, most recently
from
21ce404 to
0ee308f
Compare
|
@nforro PTAL at the post-modifications move. Thanks a lot! |
`prepare-files` action was interfering with spec file update which caused containers#2760 . `post-modifications` needs to be limited to the propose_downstream job or else it will interfere with upstream PR copr builds. Also, s/PACKIT_PROJECT_TAG/PACKIT_PROJECT_VERSION/ . Co-authored-by: Nikola Forró <[email protected]> Signed-off-by: Lokesh Mandvekar <[email protected]>
4 participants
prepare-filesaction was interfering with spec file update which caused #2760 .Note: This will only take effect during the downstream update after an upstream release. No way to verify this before upstream merge.