Makefile: fix test-system
#2730
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
`hack/test-system.sh` earlier removed in commit 7e235ea contained a storage.conf setup useful for running system tests in skopeo_cidev container. Getting rid of that also broke `make test-system` because the systemtest: `copy: additional tag` started to break. Running `make test-system-local` isn't ideal for local environments due to creation of system-global containers with predictable names. See: containers#2701 (comment) So, this commit resurrects hack/test-system.sh. Followup commit will modify Makefile targets to use this script again. Signed-off-by: Lokesh Mandvekar <[email protected]>
This will ensure both `test-system` and `test-system-local` work. The `test-system` target will use the skopeo binary at `./bin/skopeo`. Setting SKOPEO_BINARY should have no effect on it. The `test-system-local` (and `test-integration-local`) target can use SKOPEO_BINARY at any location. This will be useful in CI where we need to test skopeo installed by the package at /usr/bin. Signed-off-by: Lokesh Mandvekar <[email protected]>
|
Rebased on #2725 |
|
Obsoleted by #2731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.