main: Add support for overriding HTTP User-Agent #2724
Conversation
There was a problem hiding this comment.
I… don’t think that identifying use cases via User-Agent generalizes at all. Podman is not going to use a different User-Agent depending on operation, for example.
But, *shrug*, c/image does have DockerRegistryUserAgent so it makes sense for Skopeo to expose an option.
I read https://www.rfc-editor.org/rfc/rfc7231.html#section-5.5.3 to mean that (…) is a comment syntax, that is not what I’d expect here.
Yes, it would be unusual. But conceptually think of this as for rich enough use cases where one has a proper "application" on top of skopeo - it might be e.g. a registry which supports auto-mirroring from another registry and forks skopeo as a binary instead of vendoring the libraries because it doesn't want to hop on the CVE train.
Fixed, thanks! |
- Log data via structured logging - Include user agent (to test out containers/skopeo#2724 ) Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
user-agent
branch
2 times, most recently
from
9dfc64b to
169091e
Compare
|
Added an |
Who would that be? |
|
/lgtm |
Ah, this doesn't work anymore as I am not maintainer anymore |
AFAICS you do still have an admin role in GitHub, but we never had the bot set up. |
I want this for bootc-dev/bootc#1686 so we can distinguish pulls there. But more generally it's can be a good idea for people writing scripts using skopeo to set custom user agents so that registries can more easily trace which actors are performing tasks. Assisted-by: Claude Code Signed-off-by: Colin Walters <[email protected]>
3 participants
I want this for bootc-dev/bootc#1686 so we can distinguish pulls there.
But more generally it's can be a good idea for people writing scripts using skopeo to set custom user agents so that registries can more easily trace which actors are performing tasks.