-
Notifications
You must be signed in to change notification settings - Fork 877
Fix links to migrated storage, image and common repositories. #2689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jan Kaluza <[email protected]>
|
This does not fix CONTRIBUTING.md section about Dependencies management. I have no idea right now how to do that with monorepo - we would have to research and test. I still plan to do that, but as separate task in another PR, because that will require more time and tests. |
lsm5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@mtrmac PTAL |
mtrmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think the “external”, “user-visible” ”identity” of the libraries will now be go.podman.io/*, not the repo, won’t it?
This does not fix CONTRIBUTING.md section about Dependencies management. I have no idea right now how to do that with monorepo - we would have to research and test. I still plan to do that, but as separate task in another PR, because that will require more time and tests.
I would expect it to be substantially unchanged; the instructions will need some updates (and maybe we can assume knowledge of Go modules and remove some of the details).
| # Skopeo Roadmap | ||
|
|
||
| Skopeo intends to mostly continue to be a very thin CLI wrapper over the [https://github.com/containers/image](containers/image) library, with most features being added there, not to this repo. A typical new Skopeo feature would only add a CLI for a recent containers/image feature. | ||
| Skopeo intends to mostly continue to be a very thin CLI wrapper over the [https://github.com/containers/container-libs/tree/main/image](container-libs/image) library, with most features being added there, not to this repo. A typical new Skopeo feature would only add a CLI for a recent containers/image feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this say go.podman.io/image?
| * Container Storage backends | ||
|
|
||
| - [github.com/containers/storage](https://github.com/containers/storage) (Backend for [Podman](https://podman.io), [CRI-O](https://cri-o.io), [Buildah](https://buildah.io) and friends) | ||
| - [https://github.com/containers/container-libs/tree/main/storage](https://github.com/containers/container-libs/tree/main/storage) (Backend for [Podman](https://podman.io), [CRI-O](https://cri-o.io), [Buildah](https://buildah.io) and friends) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go.podman.io/storage?
|
|
||
| Note: `skopeo` does not require any container runtimes to be running, to do most of | ||
| its functionality. It also does not require root, unless you are copying images into a container runtime storage backend, like the docker daemon or github.com/containers/storage. | ||
| its functionality. It also does not require root, unless you are copying images into a container runtime storage backend, like the docker daemon or https://github.com/containers/container-libs/tree/main/storage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go.podman.io/storage ? Or just Podman’s storage, or maybe best containers-storage: — the syntax users use.
|
A friendly reminder that this PR had no activity for 30 days. |
|
@jankaluza friendly ping |
|
A friendly reminder that this PR had no activity for 30 days. |
No description provided.