Prepare for --sign-by-sq-fingerprint
#2650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
sequoia-cli-infra
branch
from
89b442a to
dfae8f1
Compare
mtrmac
force-pushed
the
sequoia-cli-infra
branch
from
dfae8f1 to
05d17e6
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
... to simplify users. Should not change test behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Should not change test behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Rely on "$@" to allow passing options with spaces, like SKOPEO_LDFLAGS. Then pass SKOPEO_LDFLAGS. Also fix the documentation of TESTFLAGS. Signed-off-by: Miloslav Trmač <[email protected]>
Allow passing SKOPEO_LDFLAGS and BUILDTAGS. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
sequoia-cli-infra
branch
from
05d17e6 to
203a4cf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2645 is now working and tested end-to-end, but depends on an unmerged feature.
This PR contains the required infrastructure / refactoring before the main feature, to allow reviewing / merging sooner.
(Alternatively, it would be possible to include the CLI code as well, with containers/image#2896 , but having a CLI option that can never work seems a bit overzealous, at least for now.)
See individual commit messages for details.