Skip to content

fix(e2e): remove unnecessary workaround for tests-playwright version #4683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
axel7083 wants to merge 1 commit into from
Closed

fix(e2e): remove unnecessary workaround for tests-playwright version #4683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/e2e-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,6 @@ jobs:
working-directory: ./podman-desktop
run: pnpm test:e2e:build

- name: Ensure getting current HEAD version of the test framework
working-directory: ./podman-desktop-extension-ai-lab/tests/playwright
run: pnpm add -D @podman-desktop/tests-playwright@next

- name: Execute pnpm in AI Lab Extension
working-directory: ./podman-desktop-extension-ai-lab
Expand Down
9 changes: 1 addition & 8 deletions .github/workflows/pr-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,17 +120,10 @@ jobs:
pnpm install --frozen-lockfile
pnpm test:e2e:build

- name: Ensure getting current HEAD version of the test framework
working-directory: ./podman-desktop-extension-ai-lab/tests/playwright
run: |
# workaround for https://github.com/containers/podman-desktop-extension-bootc/issues/712
version=$(npm view @podman-desktop/tests-playwright@next version)
echo "Version of @podman-desktop/tests-playwright to be used: $version"
jq --arg version "$version" '.devDependencies."@podman-desktop/tests-playwright" = $version' package.json > package.json_tmp && mv package.json_tmp package.json

- name: Execute pnpm in AI Lab Extension
working-directory: ./podman-desktop-extension-ai-lab
run: pnpm install --no-frozen-lockfile
run: pnpm install

- name: Build Image
working-directory: ./podman-desktop-extension-ai-lab
Expand Down
9 changes: 1 addition & 8 deletions .github/workflows/ramalama.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,17 +81,10 @@ jobs:
pnpm install --frozen-lockfile
pnpm test:e2e:build

- name: Ensure getting current HEAD version of the test framework
working-directory: ./podman-desktop-extension-ai-lab/tests/playwright
run: |
# workaround for https://github.com/podman-desktop/podman-desktop-extension-bootc/issues/712
version=$(npm view @podman-desktop/tests-playwright@next version)
echo "Version of @podman-desktop/tests-playwright to be used: $version"
jq --arg version "$version" '.devDependencies."@podman-desktop/tests-playwright" = $version' package.json > package.json_tmp && mv package.json_tmp package.json

- name: Execute pnpm in AI Lab Extension
working-directory: ./podman-desktop-extension-ai-lab
run: pnpm install --no-frozen-lockfile
run: pnpm install

- name: Update ramalama image references in AI Lab Extension
working-directory: ./podman-desktop-extension-ai-lab
Expand Down
Loading