Add subpath support to volumes in --mount option
#1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fccagou
force-pushed
the
fix-subpath-silently-ignored
branch
6 times, most recently
from
da088d3 to
b4728f4
Compare
To allow subpath mount as describes in [Compose Specs](https://github.com/compose-spec/compose-spec/blob/main/05-services.md), `refer_volume_over_mount` is changed from _True_ to **False** Compose entries exemple: - type: volume source: webservices target: /srv/www/vhosts/server1 read_only: true volume: subpath: server1 - type: volume source: webservices target: /srv/www/vhosts/server2 read_only: true volume: subpath: server2 - type: volume source: webservices target: /srv/www/vhosts/server2/uploads read_only: false volume: subpath: server2/uploads Runs podman with options --mount type=volume,source=webservices,target=/srv/www/vhosts/server1,ro --mount type=volume,source=webservices,target=/srv/www/vhosts/server2,ro,subpath=server2 --mount type=volume,source=webservices,target=/srv/www/vhosts/server2/uploads,subpath=server2/uploads Signed-off-by: fccagou <[email protected]>
fccagou
force-pushed
the
fix-subpath-silently-ignored
branch
from
b4728f4 to
62f1f36
Compare
fccagou
changed the title
--mount option
fccagou
force-pushed
the
fix-subpath-silently-ignored
branch
from
53ac9a7 to
3230e3c
Compare
Signed-off-by: fccagou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add subpath support to volumes in
--mountoptionTo allow subpath mount as describes in Compose Specs,
refer_volume_over_mountis changed from True to FalseCompose entries exemple:
Contributor Checklist:
If this PR adds a new feature that improves compatibility with docker-compose, please add a link
to the exact part of compose spec that the PR touches.
For any user-visible change please add a release note to newsfragments directory, e.g.
newsfragments/my_feature.feature. See newsfragments/README.md for more details.
All changes require additional unit tests.