Skip to content

Conversation

@lsm5
Copy link
Member

@lsm5 lsm5 commented Sep 25, 2025

Follow up on #6390

What type of PR is this?

/kind other

What this PR does / why we need it:

Builds fedora 43+ rpms with sequoia

How to verify it

check in build logs if buildtag has been added. Any System tests using sequoia should pass.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Merge only after #6390

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM
but it looks like you need a test, or do you want to slap the no new tests label on this?

@lsm5 lsm5 added the No New Tests Allow PR to proceed without adding regression tests label Sep 26, 2025
@lsm5
Copy link
Member Author

lsm5 commented Sep 26, 2025

label added. This should only go in after the sequoia support PR mentioned in description.

@TomSweeneyRedHat
Copy link
Member

@lsm5 is this ready to have Draft label yanked?

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Follow up on containers#6390

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
Copy link
Member Author

lsm5 commented Oct 17, 2025

I see the sequoia PR is merged. Rebased on the latest main. Once tests pass, I'll get this out of draft.

@lsm5 lsm5 marked this pull request as ready for review October 17, 2025 18:46
@lsm5
Copy link
Member Author

lsm5 commented Oct 17, 2025

@containers/buildah-maintainers PTAL, good to go.

@nalind
Copy link
Member

nalind commented Oct 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit d958aec into containers:main Oct 21, 2025
41 checks passed
@lsm5 lsm5 deleted the sequoia-rpm branch October 22, 2025 17:58
@lsm5
Copy link
Member Author

lsm5 commented Oct 22, 2025

did this not make it into v1.42?

@nalind
Copy link
Member

nalind commented Oct 22, 2025

The commit log shows the merge commit for #6439 being applied after the merge commit for this one, but the patches in it are before this one, and the first of those is where the tag was applied.

@lsm5
Copy link
Member Author

lsm5 commented Oct 23, 2025

Ack. I'll manually update dist-git to build with sequoia. No worries. If we're branching a release-1.42 upstream, then this patch should be cherrypicked there so packit won't overwrite the dist-git sequoia changes.

@nalind nalind mentioned this pull request Oct 27, 2025
@TomSweeneyRedHat
Copy link
Member

/cherry-pick release-1.42

@openshift-cherrypick-robot

@TomSweeneyRedHat: new pull request created: #6457

In response to this:

/cherry-pick release-1.42

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved kind/other lgtm No New Tests Allow PR to proceed without adding regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants