-
Notifications
You must be signed in to change notification settings - Fork 852
RPM: build with sequoia on F43+ #6395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
LGTM |
|
label added. This should only go in after the sequoia support PR mentioned in description. |
|
@lsm5 is this ready to have Draft label yanked? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Follow up on containers#6390 Signed-off-by: Lokesh Mandvekar <[email protected]>
|
I see the sequoia PR is merged. Rebased on the latest main. Once tests pass, I'll get this out of draft. |
|
@containers/buildah-maintainers PTAL, good to go. |
|
/lgtm |
|
did this not make it into v1.42? |
|
The commit log shows the merge commit for #6439 being applied after the merge commit for this one, but the patches in it are before this one, and the first of those is where the tag was applied. |
|
Ack. I'll manually update dist-git to build with sequoia. No worries. If we're branching a release-1.42 upstream, then this patch should be cherrypicked there so packit won't overwrite the dist-git sequoia changes. |
|
/cherry-pick release-1.42 |
|
@TomSweeneyRedHat: new pull request created: #6457 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Follow up on #6390
What type of PR is this?
/kind other
What this PR does / why we need it:
Builds fedora 43+ rpms with sequoia
How to verify it
check in build logs if buildtag has been added. Any System tests using sequoia should pass.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Merge only after #6390
Does this PR introduce a user-facing change?