WIP: add manifest/manifest-descriptor/index annotation levels #6322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nalind
force-pushed
the
annotation-levels
branch
3 times, most recently
from
a561201 to
c194158
Compare
openshift-merge-robot
added
the
needs-rebase
Add (some) annotation levels, where if an annotation name specified to either --annotation or --unsetannotation has a prefix of "manifest", "manifest-descriptor", or "index" (or a comma-separated list of any of them) followed by a colon, we take the annotation name as the part after the colon separator and add (or remove) the annotation from the image manifest (as before), or the image's entry in an image index that we're building (if we're building one), or the image index that we're building (if we're building one). `docker build` also recognizes "index-descriptor", so if we ever get an API for setting it in the top-level index.json when committing directly to an "oci:" or "oci-archive:", we'll want to handle that, too, but that's not available as of now. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
annotation-levels
branch
from
c194158 to
3a68c73
Compare
openshift-merge-robot
added
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
A friendly reminder that this PR had no activity for 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add (some) annotation levels, where if an annotation name specified to either --annotation or --unsetannotation has a prefix of "manifest", "manifest-descriptor", or "index" (or a comma-separated list of any of them) followed by a colon, we take the annotation name as the part after the colon separator and add (or remove) the annotation from the image manifest (as before), or the image's entry in an image index that we're building (if we're building one), or the image index that we're building (if we're building one).
How to verify it
New integration tests!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
docker buildalso recognizes "index-descriptor", so if we ever get an API for setting it in the top-level index.json when committing directly to an "oci:" or "oci-archive:", we'll want to handle that, too, but that's not available as of now.Does this PR introduce a user-facing change?