Add missing continue after stream failure#223
Merged
fuweid merged 1 commit intocontainerd:mainfrom Mar 4, 2026
Merged
Conversation
After the send status is called, a stream will be closed and cannot do more processing on the stream, including further send status. This also fixes a panic when a streamid sent to the server is not found, the send status will return and then panic attempting to convert nil to a stream handler. Signed-off-by: Derek McGowan <derek@mcg.dev>
Kern--
approved these changes
Mar 4, 2026
cpuguy83
approved these changes
Mar 4, 2026
fuweid
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the send status is called, a stream will be closed and cannot do more processing on the stream, including further send status.
This also fixes a panic when a streamid sent to the server is not found, the send status will return and then panic attempting to convert nil to a stream handler. This can happen when a server initiates a close when a client is still sending data.