Update google.golang.org/grpc #594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnylovestiramisu
force-pushed
the
updategrpc
branch
from
84cc41c to
778d00d
Compare
sunnylovestiramisu
force-pushed
the
updategrpc
branch
from
778d00d to
a2d34c2
Compare
xing-yang
reviewed
Jul 16, 2025
|
|
||
| require ( | ||
| google.golang.org/grpc v1.57.1 | ||
| google.golang.org/protobuf v1.33.0 | ||
| github.com/golang/protobuf v1.5.4 |
There was a problem hiding this comment.
How did this deprecated link become a direct reference? It should be an indirect one used by google.golang.org/protobuf internally.
xing-yang
reviewed
Jul 16, 2025
| golang.org/x/net v0.38.0 // indirect | ||
| golang.org/x/sys v0.31.0 // indirect | ||
| golang.org/x/text v0.23.0 // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20250324211829-b45e905df463 // indirect |
There was a problem hiding this comment.
I'm getting this without generated files under lib/go/csi:
module github.com/container-storage-interface/spec
go 1.23.0
toolchain go1.24.4
require (
google.golang.org/grpc v1.73.0
google.golang.org/protobuf v1.36.6
)
require (
golang.org/x/net v0.38.0 // indirect
golang.org/x/sys v0.31.0 // indirect
golang.org/x/text v0.23.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250324211829-b45e905df463 // indirect
)
|
/close |
|
/close Resolved by upgrading github.com/golang/protobuf v1.5.4 |
|
/close |
1 similar comment
|
/close |
|
Not needed anymore. Not sure why the close tag do not work anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Update google.golang.org/grpc
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce an API-breaking change?: