Skip to content

Changed version and publish chart workflow #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 42 additions & 5 deletions .github/workflows/publish-chart.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,57 @@
name: "Publish Chart"

on:
workflow_dispatch: # Allows manual triggering
pull_request:
paths:
- .github/workflows/publish_chart.yml
- chart/**
- chart/Chart.yaml
- .github/workflows/publish-chart.yml
push:
paths:
- .github/workflows/publish_chart.yml
- chart/**
- chart/Chart.yaml
- .github/workflows/publish-chart.yml
branches:
- main

jobs:
check-version-change:
runs-on: ubuntu-latest
outputs:
should_publish: ${{ steps.check-version.outputs.changed }}
steps:
- name: Checkout Code
uses: actions/checkout@v3
with:
ref: ${{ github.head_ref || github.ref_name }}
fetch-depth: 0

- name: Check if Chart Version Changed
id: check-version
if: github.event_name != 'workflow_dispatch' # Skip if manually triggered
run: |
if git diff --name-only HEAD^ HEAD | grep -q 'chart/Chart.yaml'; then
PREVIOUS_VERSION=$(git show HEAD^:chart/Chart.yaml | grep 'version:' | awk '{print $2}')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Chart.yaml did not exist in the previous commit (e.g. the file was just added), git show HEAD^:chart/Chart.yaml returns a non-zero status which, together with set -eo pipefail used by GitHub runners, terminates the whole step and aborts the workflow. Guard the command or swallow the error so the version-check logic can proceed safely.

CURRENT_VERSION=$(grep 'version:' chart/Chart.yaml | awk '{print $2}')

if [ "$PREVIOUS_VERSION" != "$CURRENT_VERSION" ]; then
echo "Version changed from $PREVIOUS_VERSION to $CURRENT_VERSION"
echo "changed=true" >> $GITHUB_OUTPUT
else
echo "Version didn't change ($CURRENT_VERSION)"
echo "changed=false" >> $GITHUB_OUTPUT
fi
else
echo "Chart.yaml wasn't modified"
echo "changed=false" >> $GITHUB_OUTPUT
fi

- name: Set Publish Flag for Manual Runs
if: github.event_name == 'workflow_dispatch'
run: echo "changed=true" >> $GITHUB_OUTPUT

publish-chart:
needs: check-version-change
if: needs.check-version-change.outputs.should_publish == 'true' || github.event_name == 'workflow_dispatch'
runs-on: ubuntu-latest
steps:
- name: Checkout Code
Expand All @@ -38,4 +76,3 @@ jobs:

- name: Push Packaged Chart to Registry
run: helm push ./tmp/* oci://${{ vars.REGISTRY_ADDR }}/library

15 changes: 12 additions & 3 deletions do.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,21 @@ build_push_image() {
}

build_push_chart() {
version=$(cat VERSION)
# Ensure prerequisites are available
if ! command -v yq >/dev/null 2>&1; then
echo "Error: 'yq' is required but not installed." >&2
exit 1
fi
if [ ! -f chart/Chart.yaml ]; then
echo "Error: chart/Chart.yaml not found." >&2
exit 1
fi
version=$(yq -r '.version' chart/Chart.yaml)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yq command is invoked with the -r flag but without the required sub-command (e|eval) that newer versions of mikefarah/yq expect; this exits with "unknown shorthand flag" and stops the build script (set -e).

helm package chart
helm push helm-charts-oci-proxy-$version.tgz oci://8gears.container-registry.com/library
helm push "helm-charts-oci-proxy-${version}.tgz" \
"oci://8gears.container-registry.com/library"
}


deploy() {
helm upgrade -i --namespace ocip-staging --create-namespace ocip-staging ./chart
}
Expand Down