-
Notifications
You must be signed in to change notification settings - Fork 12
Changed version and publish chart workflow #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MarkBogelund
wants to merge
3
commits into
container-registry:main
Choose a base branch
from
MarkBogelund:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
be078d4
Modified the build_push_chart so it gets the version from chart/Chart…
MarkBogelund e2d0d13
modified the publish chart workflow to only run on manual trigger or …
MarkBogelund 156f81e
added suggestion from coderabbitai for error handling in the build_pu…
MarkBogelund File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,12 +15,21 @@ build_push_image() { | |
} | ||
|
||
build_push_chart() { | ||
version=$(cat VERSION) | ||
# Ensure prerequisites are available | ||
if ! command -v yq >/dev/null 2>&1; then | ||
echo "Error: 'yq' is required but not installed." >&2 | ||
exit 1 | ||
fi | ||
if [ ! -f chart/Chart.yaml ]; then | ||
echo "Error: chart/Chart.yaml not found." >&2 | ||
exit 1 | ||
fi | ||
version=$(yq -r '.version' chart/Chart.yaml) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The yq command is invoked with the -r flag but without the required sub-command (e|eval) that newer versions of mikefarah/yq expect; this exits with "unknown shorthand flag" and stops the build script (set -e). |
||
helm package chart | ||
helm push helm-charts-oci-proxy-$version.tgz oci://8gears.container-registry.com/library | ||
helm push "helm-charts-oci-proxy-${version}.tgz" \ | ||
"oci://8gears.container-registry.com/library" | ||
} | ||
|
||
|
||
deploy() { | ||
helm upgrade -i --namespace ocip-staging --create-namespace ocip-staging ./chart | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Chart.yaml did not exist in the previous commit (e.g. the file was just added),
git show HEAD^:chart/Chart.yaml
returns a non-zero status which, together withset -eo pipefail
used by GitHub runners, terminates the whole step and aborts the workflow. Guard the command or swallow the error so the version-check logic can proceed safely.