fix: Improve long press tap command with proper duration handling - #6
Closed
conorluddy wants to merge 1 commit into
Closed
fix: Improve long press tap command with proper duration handling#6conorluddy wants to merge 1 commit into
conorluddy wants to merge 1 commit into
Conversation
- Add --duration parameter to tap_and_hold method - Convert duration from seconds to milliseconds for IDB compatibility - Remove unnecessary time.sleep() since IDB handles duration natively - Maintains backward compatibility with existing long press calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the long press gesture command by properly utilizing IDB's built-in duration parameter instead of simulating with delays.
Changes
--durationparameter totap_and_hold()method in gesture.pytime.sleep()since IDB handles duration nativelyTesting
int(duration * 1000)(e.g., 2.0 seconds = 2000ms)Technical Details
IDB's
idb ui tapcommand supports--durationparameter in milliseconds:🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com