-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and test #26
base: main
Are you sure you want to change the base?
Conversation
@spejman Wow! This is incredible. Thank you so much for all of the work you've put into this! The reason I hadn't split it up originally (and why I stopped working on the TypeScript branch) is because I wanted to make using the script very accessible with a single curl. It's definitely gained more usage than I ever expected so I guess it would be best to create an NPM package. The testing suite has become a necessity so I can't thank you enough for that as well. I'll review this in-depth tonight and likely complete the pull request then. |
@spejman I'm having issues getting this to run - I think this is a good idea, but it's going to need some work before it can be merged. I'll take a closer look as soon as I can but I'll be really busy for a while so I can't make any guarantees to my timeline. Thank you! |
Hi @connertennery ! Sorry I didn't have the notifications properly configured and didn't get the notification of your comments. I just checked your comments and noticed that my last merge 'main' broke the code, I just fixed it, it should work as expected now. |
I also just used Thanks! |
A proposal to refactor the code in different files split per functionality:
Also added two files with a small set of tests that ensures the script behaves as expected, and also speeds up the development because you can easily add a test with the bug that is failing and run the tests after each code change to ensure it's fixed.