Repository navigation
fix(bin): add missing JAR directory to windows batch script - #3553
Closed
Alejandro G. Peregrina (agperegrina) wants to merge 7 commits into
Closed
Alejandro G. Peregrina (agperegrina) wants to merge 7 commits into
Alejandro G. Peregrina (agperegrina) wants to merge 7 commits into
Conversation
Alejandro G. Peregrina (agperegrina)
requested a review
from a team
as a code owner
February 7, 2025 09:18
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixed the windows batch file in a way that Confluent Community Edition schema-registry works without docker. There are only symlinks—instead of the actual JARs for the needed dependencies—in the folders added to the
:concatjump goto label that fills the%CLASSPATH%. Thus, this change adds the missing classes that are in theksqldbdirectory solving this issue.See also: confluentinc/kafka#1581
Checklist
Test & Review
Before:

After
